Skip to content

Remove legacy callback argument from group method

Jiaan Louw requested to merge 217349-remove-legacy-callback into master

What does this MR do?

Update callback to be an optional argument on 'group(id, callback)' in api.js. Reason:

our callback is pretty legacy, I suggest adding callback = () => {} to api.js instead and to have clean Api.group(id) request :)

Issue: #217349 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #217349 (closed)

Edited by Jiaan Louw

Merge request reports