Skip to content

Fix invisible modal on status emoji selection

Adam Hegyi requested to merge fix-selecting-status-emoji-twice into master

What does this MR do?

I ran into this issue several times when changing my status.

This change fixes a bug where the status emoji is not visible after the second click on the emoji selector icon.

How to reproduce:

  1. Click on your user avatar (top right corner)
  2. Set status
  3. Click on the emoji selector icon
  4. Select an emoji
  5. Click on the emoji selector icon again
  6. Emoji selector is not showing up

Expected: Emoji selector should show up.

The bug is caused by a global click event listener that very quickly closes the already bootstrapped (component is rendered but not visible) emoji selector:

https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/awards_handler.js#L69

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports