Skip to content

Added producing of new emoji map which will be loaded async in the future

Tim Zallmann requested to merge tz-new-emojis-json into master

What does this MR do?

Adds to our current way of creating the emojis digests.json a parallel way with a file that doesn't include hashes anymore and will be much smaller and loaded in the future async through AJAX and cached in localstorage instead of being included in main.js (currently 30% of the loaded JS bundle on each page).

Current digests.json 384kb

New emojis.json 189kb

This can be executed by bundle exec rake gemojione:digests

It is simply the first iterative step to make it possible in the next step to just load the new emojis.json async in another MR. At a later stage when we switched the loading mechanism we will remove the old digests.json code.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tim Zallmann

Merge request reports