Skip to content

Move jquery.waitforimages import away from main

Lukas Eipert requested to merge leipert-move-wait-for-images into master

What does this MR do?

Move jquery.waitforimages import away from main

This moves the import of jquery.waitforimages from main to

  • app/assets/javascripts/commit/image_file.js
  • app/assets/javascripts/pages/projects/show/index.js
  • app/assets/javascripts/pages/projects/tree/show/index.js

These are the only files which utilize it and thus we don't need to load it on every page.

The issue to replace it completely can be found here: #219370 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports