Include CI_MERGE_REQUEST_IID check in Code Quality rules
What does this MR do?
From gitlab-development-kit!1270 (comment 350726331)
if: '$CI_COMMIT_TAG || $CI_COMMIT_BRANCH'doesn't seem to work in the context of merge request pipelines
This MR adds $CI_MERGE_REQUEST_IID in the if check. I don't see any reason why we wouldn't want to run the job in MR pipelines so this seems to be a bug.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team