Skip to content

Fix NoMethodError when reporting exceptions to Sentry

Fabio Pitino requested to merge fix-invalid-error-tracking-method into master

What does this MR do?

I found this bug by chance. We were using Gitlab::ErrorTracking.track_error method which does not exist, instead of track_exception.

This wasn't caught in specs because of method mocking.

Error is also visible in https://sentry.gitlab.net/gitlab/gitlabcom/?query=is%3Aunresolved+track_error

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports