Skip to content

Add Max import file size option

Roger Meier requested to merge siemens/gitlab:fix/max_import_size into master

What does this MR do?

This adds an option to the Admin page to set the Maximum Import Filesize.

Closes #216938 (closed)

🛠 with at Siemens

Screenshots

Screenshot_2020-06-05_at_15.13.10

DB migration

bundle exec rake db:migrate:up VERSION=20200527211000
== 20200527211000 AddMaxImportSize: migrating =================================
-- add_column(:application_settings, :max_import_size, :integer, {:default=>50, :null=>false})
   -> 0.0457s
== 20200527211000 AddMaxImportSize: migrated (0.0674s) ========================

bundle exec rake db:migrate:down VERSION=20200527211000
== 20200527211000 AddMaxImportSize: reverting =================================
-- remove_column(:application_settings, :max_import_size)
   -> 0.0082s
== 20200527211000 AddMaxImportSize: reverted (0.0084s) ========================

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Jang

Merge request reports