What does this MR do?
Implementation of #219395 (closed)
It adds basic validations for metrics dashboard YAML definitions by extending existing implementation with blob show in
auxiliary viewer which is used for
.gitlab-ci.yml. Upon displaying file from
.gitlab/dashboards directory, additional ajax request is made to perform basic validation, and display its results. For the MVC validation process stops at first entry which is invalid and reports encountered errors
Implemented validations (all are available in review apps while browsing different files at https://gitlab-review-mwaw-21028-4p588v.gitlab-review.app/gitlab-qa-sandbox-group/qa-test-2020-05-28-08-20-15-2110ca8d56e4a554/autodevops-project-510a79b8219de037/-/tree/master/.gitlab/dashboards):
Does this MR meet the acceptance criteria?
Documentation (if required)
Code review guidelines
Merge request performance guidelines
Separation of EE specific content
Availability and Testing
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Tested in all supported browsers
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
Label as security and @ mention
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team