Skip to content

Remove order clauses from the limited counter helper

Marius Bobin requested to merge improve_limited_counter_with_delimiter into master

What does this MR do?

NumbersHelper#limited_counter_with_delimiter was executing a count on the relationship without removing the order clause which resulted in poor query execution for the pipelines index page. More info: !32687 (comment 349581339)

This MR replaces the counting code from this module with the more robust implementation from Kaminari.

Relates to #217748 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marius Bobin

Merge request reports