Fix canRemove check in boards sidebar
What does this MR do?
canRemove from https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/boards/components/board_sidebar.js#L56 is used on 2 places - when clicking an issue in a list and when clicking the list settings icon. It is needed in order to decide if remote issue button should be visible. Therefore the check is not needed for the list settings, this.list is not present in that case.
We apparently use the board_sidebar.js for the list settings so this seems the easiest way how to fix. I am happy to hear a better solution!
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team