Skip to content

Change SpamVerdictService GET to POST

charlie ablett requested to merge cablett-spam-endpoint-post into master

What does this MR do?

Modify external spam endpoint to use POST instead of GET. This means that we can send more parameters, they will be hidden within the request body (rather than part of the URL) and won't be affected by URL length restrictions.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/217110

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by charlie ablett

Merge request reports