Skip to content

Improve checks for path traversal validation

Juliet Wanjohi requested to merge jwanjohi_improve_path_traversal_check into master

What does this MR do?

  • Check that path parameter does not contain multiple URL encoding
  • Replace allow_absolute parameter with an array of allowed absolute paths (default to empty as we currently don't allow absolute paths)
  • Check that the path parameter is not absolute unless it explicitly matches one of the allowed absolute paths.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Juliet Wanjohi

Merge request reports