Skip to content

Persist JUnit data when a build is finished

Max Orefice requested to merge mo-persist-junit-data-build-finished into master

Part of #211838 (closed)

This feature will be behind a feature flag. The full feature has been developed on this POC branch.

What does this MR do?

This MR persists our JUnit data within our new model BuildReportResult introduced in !32991 (merged).

It includes the following items:

  • Adds JUnit accessors for deserialization
  • Adds BuildReportResultWorker
  • Adds BuildReportResultService

Why are we doing this?

Today our JUnit feature is really slow for big projects containing a lot of tests and requires almost 1min on gitlab.com in order to render the data. We are working toward improving the ~performance of this feature and we decided by starting to persist our counter data which is all the data you can see on the screenshot below 👇

Pipeline___GitLab.org___GitLab___GitLab_2020-05-25_14-51-16

Context

This MR represents a vertical slice of functionality for improving the ~performance of our JUnit feature. This is slice 2/3.

This work will occur in 3 slices:

  1. Create data model - !32991 (merged).
  2. Populate new data once a build is finished - !33093 (merged)
  3. Expose the new API at the pipeline level - !33431 (merged)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports