Skip to content

WIP: Cluster list refactor: Add missing icons (Import Svgs)

Emily Ring requested to merge emilyring-cluster-list-refactor-provider-svg into master

What does this MR do?

The current Cluster Index View has the following code:

- if Feature.enabled?(:clusters_list_redesign)
      #js-clusters-list-app{ data: { endpoint: clusterable.index_path(format: :json) } }
    - else
      .clusters-table.js-clusters-list
        .gl-responsive-table-row.table-row-header{ role: "row" }
          .table-section.section-60{ role: "rowheader" }
            = s_("ClusterIntegration|Kubernetes cluster")
          .table-section.section-30{ role: "rowheader" }
            = s_("ClusterIntegration|Environment scope")
          .table-section.section-10{ role: "rowheader" }
        - @clusters.each do |cluster|
          = render "cluster", cluster: cluster.present(current_user: current_user)
      = paginate @clusters, theme: "gitlab"

Feature.enabled?(:clusters_list_redesign) is part of a redesign where we:

  • Refactor/Move the cluster list from haml to vue
  • Add additional columns to the cluster table. (See related Epic: &2666 (closed))

Currently, the haml section includes an icon = provider_icon(cluster.provider_type) but the JS is missing the icon

This MR will:

  • Add provider icons to the vue
  • Add provider_type to the JSON response
  • Update associated tests

Screenshots

image

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports