Bulk edit health status
What does this MR do?
Feature flag - :bulk_update_health_status
Screenshots
Closed view:
Open view:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.1
added devopsplan frontend typefeature labels
2 Warnings 
This merge request is quite big (more than 537 lines changed), please consider splitting it into multiple merge requests. This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslintrules. Please consider fixing them:app/assets/javascripts/issuable_bulk_update_actions.jsapp/assets/javascripts/issuable_bulk_update_sidebar.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/issuable_bulk_update_actions.js' \ 'app/assets/javascripts/issuable_bulk_update_sidebar.js'Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Justin Ho ( @justin_ho)Natalia Tepluhina ( @ntepluhina)backend Arturo Herrero ( @arturoherrero)Mayra Cabrera ( @mayra-cabrera)test Quality for spec/features/*Désirée Chevalier ( @dchevalier2)Maintainer review is optional for test Quality for spec/features/*If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by 🤖 GitLab Bot 🤖-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6047bf27 and 6143f05f
Entrypoint / Name Size before Size after Diff Diff in percent average 4.01 MB 4.01 MB - 0.0 % mainChunk 3.12 MB 3.12 MB - 0.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.merge_requests 406.74 KB 454.21 KB +47.47 KB 11.7 % pages.projects.merge_requests.index 456.93 KB 504.4 KB +47.47 KB 10.4 % pages.groups.epics.index 1.02 MB 1.06 MB +43.61 KB 4.2 % pages.groups.issues 637.27 KB 680.88 KB +43.61 KB 6.8 % pages.projects.issues.index 693.34 KB 736.95 KB +43.61 KB 6.3 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@justin_ho,@leipertor@mikegreiling) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
added frontend label
added 251 commits
-
f05544b5...62f113fe - 250 commits from branch
master - f3de4967 - Bulk edit health status
-
f05544b5...62f113fe - 250 commits from branch
mentioned in merge request !32875 (merged)
added direction groupproduct planning labels
added GitLab Ultimate label
removed epics label
assigned to @uhlexsis
Resolved by Rajat Jain@uhlexsis: Can you please review this? Thanks
- Last reply by Alexis Ginsberg
- Resolved by Rajat Jain
@egrieff: Hi, one quick question, what value do you want me to send out when the user select
No statusas a health status. I've tried sendingnull,undefined,0, etc. but nothing seems to work.Here's the payload:
- Last reply by Eugenia Grieff
added 1252 commits
-
5d80a0f3...04a60057 - 1251 commits from branch
master - 1eb7b7b9 - Bulk edit health status
-
5d80a0f3...04a60057 - 1251 commits from branch
assigned to @kushalpandya
- Resolved by Kushal Pandya
@kushalpandya Can you please review this?
- Last reply by Kushal Pandya
unassigned @kushalpandya
added 437 commits
-
fd3bacab...3d16fa67 - 436 commits from branch
master - 4179c381 - Bulk edit health status
-
fd3bacab...3d16fa67 - 436 commits from branch
added 1 commit
- b219c8ea - Add allowed empty params to bulk update service
added backend label
assigned to @egrieff
mentioned in merge request !34256 (merged)
assigned to @kushalpandya
- Resolved by Jan Provaznik
@alexbuijs Can you please review the backend here? Thanks
- Last reply by Jan Provaznik
assigned to @alexbuijs
unassigned @kushalpandya
assigned to @kushalpandya
unassigned @kushalpandya
added 1130 commits
-
446769b8...0ae2aa1c - 1126 commits from branch
master - a9c18be9 - Bulk edit health status
- 965836bf - Filter bulk update service params
- a631ac97 - Change health status constants to use 0
- cc55e7f1 - Allow health status to be reset
Toggle commit list-
446769b8...0ae2aa1c - 1126 commits from branch
assigned to @jprovaznik and unassigned @alexbuijs
unassigned @jprovaznik
added 484 commits
-
cc55e7f1...0ad4044f - 480 commits from branch
master - c7755c6b - Bulk edit health status
- 060f1ea9 - Filter bulk update service params
- d7dd1d84 - Change health status constants to use 0
- 0c30bbd1 - Allow health status to be reset
Toggle commit list-
cc55e7f1...0ad4044f - 480 commits from branch
- Resolved by Jan Provaznik
@alexbuijs Thanks for the detailed review
I've applied your suggestions, could you take a look again, please?
- Last reply by Alex Buijs
assigned to @alexbuijs
changed milestone to %13.2
added missed:13.1 label
assigned to @jprovaznik and unassigned @alexbuijs
- Resolved by Jan Provaznik
Thanks @egrieff, @rajatgitlab, overall this looks good! I left a couple of comments inline, but these are minor.
- Last reply by Eugenia Grieff
unassigned @jprovaznik
added 1256 commits
Toggle commit listassigned to @jprovaznik
- Resolved by Jan Provaznik
Thanks @egrieff, LGTM except one change (hopefully it will solve the failing specs too).
- Last reply by Eugenia Grieff
unassigned @jprovaznik
assigned to @jprovaznik
marked the checklist item Changelog entry as completed
Thanks @egrieff, LGTM
enabled an automatic merge when the pipeline for 2360bbc1 succeeds
mentioned in commit ce5c8c67
mentioned in issue gitlab-foss#78627 (moved)
7 7 import issueStatusSelect from './issue_status_select'; 8 8 import subscriptionSelect from './subscription_select'; 9 9 import LabelsSelect from './labels_select'; 10 import HealthStatusSelect from 'ee_else_ce/vue_shared/components/sidebar/health_status_select/health_status_bundle'; @rajatgitlab @jprovaznik This fails in FOSS as I think the file needs to exists in FOSS at
app/assets/javascripts/vue_shared/components/sidebar/health_status_select/health_status_bundle: gitlab-foss#78627 (moved)
mentioned in issue #227004 (closed)
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
