Send variables parameter as a Hash to the Prometheus proxy API
What does this MR do?
Our Prometheus proxy GET API currently accepts the variables query parameter as an array. Unfortunately, we have observed that the order of elements in the array can be changed by components between the frontend and backend.
In the backend, an array like ['variable1', 'value1', 'variable2', 'value2'] is transformed into a Hash {'variable1' => 'value1', 'variable2' => 'value2'}.
To avoid the problems caused by inconsistent ordering of elements, we are now changing the format of the variables query parameter to a Hash.
| Before | After |
|---|---|
| variables[]=key1 variables[]=value1 variables[]=key2 variables[]=value2 |
variables[key1]=value1 variables[key2]=value2 |
Mentions: #219179 (closed)
The confidential issue where we did the research #218312
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team