Skip to content

WIP: Remove unused code

Kassio Borges requested to merge kborges/remove-github-sleep-from-code into master

What does this MR do?

#219100 (closed)

Remove unused code.

It seems that the Github importer was created with two possible code paths in mind, parallel processing and non-parallel processing. The non-parallel is not being used, so this MR aims to remove the unused code.

References

$ ag '\bGithubImport::Client.new'
lib/tasks/import.rake
107:    @client = Gitlab::GithubImport::Client.new(token)

lib/gitlab/github_import/client.rb
11:    #     client = GithubImport::Client.new('hunter2')

$ ag '\bGithubImport.new_client_for'
app/workers/concerns/gitlab/github_import/stage_methods.rb
10:        client = GithubImport.new_client_for(project)

app/workers/concerns/gitlab/github_import/rescheduling_methods.rb
17:        client = GithubImport.new_client_for(project, parallel: true)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports