Skip to content

Alt_usage_data failing undefined method `values' for -1:Integer

What does this MR do?

Adjust the usage of alt_usage_data

version-app is not ready to accept for all attributes integer values -1 and fails when importing usage_data

We get exceptions https://sentry.gitlab.net/gitlab/versiongitlabcom/issues/1599648/

Notice alert in version app channel

Screenshot_2020-05-25_at_16.24.13

With this MR we adjust the usage of alt_usage_data with specific fallbacks considering the expected data type on version-app

  • string -> fallback: "-1"
  • integer -> fallback -1
  • boolean -> fallback: nil
  • array of strings -> ["-1"]
  • hash: { major: -1 })

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #218299 (closed)

Edited by Alina Mihaila

Merge request reports