Skip to content

Resolve "Number of required approvals is counterintuitive on the merge request list"

Marc Shaw requested to merge 213435-optional-approvals-count into master

What does this MR do?

The related issue: #213435 (closed)

This merge request is to provide a method for the frontend to display the tool tip once a merge request is approved. This method should return the total number of people who have approved this MR, both required and optional approvers.

image__3_

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports