Skip to content

WIP: (Prototype) Update Tf Plan Error Messages

Emily Ring requested to merge emilyring-tf-plan-refactor into master

What does this MR do?

Currently, the Tfplan class obtains JSON from the customer and uses the JSON to generate a terraform artifact.

image

Since the JSON is generated by the customer, there are a lot of issues related to generating the report.

There is also a semi-related epic about how GitLab should send better error messages to the customer.

The MR will:

  • Remove the valid_supported_keys? validation. Even if the JSON parse fails, we should still allow the job_path field to create and generate a button for the customer.
  • Update TfPlan error text to include better errors messages and a link to the documentation

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports