Skip to content

Modify "Remove Rubocop::Cop::InjectEnterpriseEditionModule" to allow multiple injects

What does this MR do?

We have places where we need to prepend twice and we'd have to disable this cop. Example: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/services/projects/import_service.rb#L152

This MR modifies Rubocop::Cop::InjectEnterpriseEditionModule cop so that it allows multiple prepends, extends, and includes as long as they're all at the end.

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #207745 (closed)

Edited by Yorick Peterse

Merge request reports