Clean up unnecessary actions
What does this MR do?
While doing work for #33867 I came across these two actions that aren't necessary.
This MR deletes those actions.
They are 1:1 wrappers (no extra logic) around a single commit (each).
They are only used in other actions in the same file, and not used anywhere else in the codebase.
Based on this comment and the way our Vuex documentation is written, I believe directly committing where needed is preferred.
Other than the above "more correctness", I also believe this has at least two other benefits:
- We can delete some test code - the commits are already tested, and less test code is less code to maintain
- This will make future work I'm doing in the diffs actions a little easier by being less indirect / more direct
Screenshots
N/A, this is all ~backstage
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph