Generate metrics on commit
What does this MR do?
Related to #215166 (closed). This should, in theory, resolve this issue by ensuring the parent record is saved before trying to generate metrics.
Summary of the findings below
This change works because it pulls the metrics generation outside of the main ActiveRecord transaction for saving the parent record. The issue with inconsistency is caused by our retry logic, which is being triggered by long-running IO being performed inside ActiveRecord callbacks.
This MR is still beneficial in that it stops the linked error from occurring, which should mean we get more useful errors that point to the real cause.
See the follow-up issue to track the next steps on this.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team