[RUN AS-IF-FOSS] Move review related services outside EE
What does this MR do?
Another step to moving Review feature to Core.
This focuses on moving all DraftNotes
services and related logic to review notifications/emails only.
Models MR: !32631 (merged)
Controllers/Workers/etc MR: !32663 (merged)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.1
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Zamir Martins Filho ( @zmartins
)Ash McKenzie ( @ashmckenzie
)frontend Robert Hunt ( @rob.hunt
)Mark Florian ( @markrian
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added backstage [DEPRECATED] label
mentioned in merge request !32631 (merged)
mentioned in merge request !32663 (merged)
Hi @iamphill, another FYI, this implements the 3rd step listed on #28154 (comment 344352948). This is dependent on !32631 (merged).
This also contains some email template changes because they were moved and linter is complaining that some text aren't translated, can you please review them as frontend reviewer/maintainer? Thanks!
Edited by Patrick Bajaoassigned to @iamphill
- Resolved by Igor Drozdov
assigned to @kerrizor
- Resolved by Igor Drozdov
unassigned @iamphill
- Resolved by Patrick Bajao
unassigned @kerrizor
added 395 commits
-
5798b1d3...ca983dcc - 394 commits from branch
28154-move-models-outside-ee
- b92a5b44 - Move review related services outside EE
-
5798b1d3...ca983dcc - 394 commits from branch
added 395 commits
-
b92a5b44...f5d713a9 - 394 commits from branch
28154-move-models-outside-ee
- 3ed996c5 - Move review related services outside EE
-
b92a5b44...f5d713a9 - 394 commits from branch
added 28 commits
-
3ed996c5...802fad1c - 27 commits from branch
28154-move-models-outside-ee
- 88e6d4db - Move review related services outside EE
-
3ed996c5...802fad1c - 27 commits from branch
added 200 commits
-
88e6d4db...5052d5ac - 199 commits from branch
master
- 64d035a6 - Move review related services outside EE
-
88e6d4db...5052d5ac - 199 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 090ce6a2 and 64d035a6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.02 MB 4.02 MB - 0.0 % mainChunk 3.16 MB 3.16 MB - 0.0 %
Note: We do not have exact data for 090ce6a2. So we have used data from: 759d4d37.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @igor.drozdov
enabled an automatic merge when the pipeline for 294cf7db succeeds
mentioned in commit 63cfff7f
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !33167 (merged)
added groupcode review label and removed groupsource code label