Skip to content
Snippets Groups Projects

[RUN AS-IF-FOSS] Move review related services outside EE

Merged Patrick Bajao requested to merge 28154-move-services-outside-ee into master
All threads resolved!

What does this MR do?

Another step to moving Review feature to Core.

This focuses on moving all DraftNotes services and related logic to review notifications/emails only.

Models MR: !32631 (merged)

Controllers/Workers/etc MR: !32663 (merged)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#28154 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Patrick Bajao changed the description

    changed the description

  • Phil Hughes approved this merge request

    approved this merge request

  • Patrick Bajao added 395 commits

    added 395 commits

    Compare with previous version

  • Patrick Bajao added 395 commits

    added 395 commits

    Compare with previous version

  • Patrick Bajao added 28 commits

    added 28 commits

    Compare with previous version

  • Patrick Bajao changed target branch from 28154-move-models-outside-ee to master

    changed target branch from 28154-move-models-outside-ee to master

  • Patrick Bajao added 200 commits

    added 200 commits

    Compare with previous version

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 090ce6a2 and 64d035a6

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.02 MB 4.02 MB - 0.0 %
    mainChunk 3.16 MB 3.16 MB - 0.0 %

    Note: We do not have exact data for 090ce6a2. So we have used data from: 759d4d37.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Igor Drozdov approved this merge request

    approved this merge request

  • Igor Drozdov resolved all threads

    resolved all threads

  • Igor Drozdov enabled an automatic merge when the pipeline for 294cf7db succeeds

    enabled an automatic merge when the pipeline for 294cf7db succeeds

  • merged

  • Igor Drozdov mentioned in commit 63cfff7f

    mentioned in commit 63cfff7f

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Patrick Bajao mentioned in merge request !33167 (merged)

    mentioned in merge request !33167 (merged)

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • added groupcode review label and removed groupsource code label

  • Please register or sign in to reply
    Loading