Skip to content

Hid copy contents button on render error

Denys Mishunov requested to merge 218510-hide-copy-btn-for-rendering-error into master

What does this MR do?

It hides the "copy contents" button when a blob has a render error.

When a blob returns a render error, we do not have the blob's content, hence there's nothing to copy. That's why we hide the button in these cases. However, if, for example, user forces loading the content (in case of a collapsed blob), we do render the button again.

Screenshots

Before After
Collapsed blob. Before Screenshot_2020-05-20_at_08.52.11
Collapsed blob (default view) Collapsed blob (forced loading)
Screenshot_2020-05-20_at_08.52.11 Screenshot_2020-05-20_at_08.54.16

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #218510 (closed)

Merge request reports