Skip to content

Remove sanitize-html dependency from the main bundle

Mike Greiling requested to merge mg-remove-sanitize-html-from-main-bundle into master

What does this MR do?

The sanitize-html dependency is used by our "frequent items" dropdown for projects and groups, and this is a fairly large library. Since it pertains to something that is hidden by default, it does not make sense to require the rest of the page to wait for it to be downloaded and parsed.

This MR does two things:

  • refactors frequent_items/index.js to no longer have side-effects in import
  • turns frequent_items/components/app.vue into a dynamically loaded module

Screenshots

before after
before after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Takuya Noguchi

Merge request reports