Skip to content

Add application limits to instance level CI/CD variables

What does this MR do?

Related to #216097 (closed)

Adds a hard limit on how many instance level CI/CD variables can be defined.

bin/rake db:migrate

== 20200519141534 AddInstanceLevelVariablesColumnToPlanLimits: migrating ======
-- add_column(:plan_limits, :ci_instance_level_variables, :integer, {:default=>25, :null=>false})
   -> 0.0041s
== 20200519141534 AddInstanceLevelVariablesColumnToPlanLimits: migrated (0.0042s)

bin/rake db:rollback

== 20200519141534 AddInstanceLevelVariablesColumnToPlanLimits: reverting ======
-- remove_column(:plan_limits, :ci_instance_level_variables, :integer, {:default=>25, :null=>false})
   -> 0.0014s
== 20200519141534 AddInstanceLevelVariablesColumnToPlanLimits: reverted (0.0028s)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports