Skip to content

Fix pages build locking problem

Furkan Ayhan requested to merge atomic-pages-deploy-stuck into master

What does this MR do?

This MR aims to fix optimistic lock problem when trying to process pages build.

Atomic processing uses update_as_processed! method, and it updates lock_version of jobs. So it causes ActiveRecord::StaleObjectError in some places.

Detailed bug information: #197930 (comment 343026853)

Screenshots

Screen_Shot_2020-05-19_at_16.34.06

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports