Bump Rails to 6.0.3.1
What does this MR do?
https://weblog.rubyonrails.org/2020/5/18/Rails-5-2-4-3-and-6-0-3-1-have-been-released/
Bump Rails to 6.0.3.1
Also, Upgrade ActionCable npm package. This is to match our Rails version 6.0.3.1. There are no changes to actioncable for this upgrade
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.1
We'd want to upgrade the
Gemfile
inqa/
too. Though that could be in a separate MR.Also Gitaly. I could just change gitaly!2144 (merged) to use 6.0.3.1 if this gets merged first.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Tyler Amos ( @tyleramos
)Dylan Griffith ( @DylanGriffith
)frontend Dennis Tang ( @dennis
)Tim Zallmann ( @timzallmann
)QA Tomislav Nikić ( @tmslvnkc
)Dan Davison ( @ddavison
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 2 commits
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/pipelines/147366407 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/pipelines/147376575 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/pipelines/147376575 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/pipelines/147389443 downstream.The
gitlab-qa
downstream pipeline failed! .Looks like
ee-kubernetes
failed - https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/558221939. But it does not look related to the rails upgrade.
marked the checklist item Code review guidelines as completed
mentioned in merge request gitaly!2144 (merged)
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
- Resolved by Andrew Fontaine
@mkaeppler, @jivanvl, and @jennielouie Can you please help review this MR ?
Edited by Thong Kuah
assigned to @mkaeppler, @jivanvl, and @jennielouie and unassigned @tkuah