Skip to content

Deprecate `Gitlab::Database.bulk_insert`

Andreas Brandl requested to merge ab/bulk-insert-cop into master

What does this MR do?

As suggested in #207989 (closed), this deprecates use of Gitlab::Database.bulk_insert into favor of the BulkInsertSafe concern.

This adds a rubocop to complain about using Gitlab::Database.bulk_insert and adds ignore flags to the existing 28 occurrences where we're already using it.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports