Support EditorConfig inside of the Web IDE
What does this MR do?
Issue: #23352 (closed)
This MR adds support for fetching and parsing .editorconfig
files and applying those rules to open files in Monaco. Some
~backstage ground work for this MR to work properly was done in !32420 (merged) and !32857 (merged).
It uses two third party libraries: editorconfig
and minimatch
.
The editorconfig
library uses a lot of Node.js heavy stuff like usage of fs
, so we only use the editorconfig .ini
parser in editorconfig/lib/ini
and combine that with minimatch
for parsing globs.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor