Skip to content

Fix two button submitting of merge request reviews

Phil Hughes requested to merge ph/212334/batchCommentsTwoButtonSubmit into master

What does this MR do?

Fixes the 2 button clicking to submit a merge request review by removing the split button that opens the pending comments dropdown, and having this dropdown as a separate button. This also removes the discard review button.

All the components here have also been replaced to use the GitLab UI components.

Screenshots

Screenshot_2020-06-18_at_12.18.39

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #212334 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports