Skip to content

Revert max-width set on mermaid charts

Himanshu Kapoor requested to merge himkp-revert-mermaid-charts-fix into master

What does this MR do?

This reverts MR !25016 (merged). While that MR did fix width of mermaid charts that are too wide for display, it broke the default mermaid charts. Now they are too large.

See examples below:

graph TD;
  A-->B;
  B-->C;
graph TD;
  A-->B;
  A-->C;
  B-->D;
  C-->D;

Graph 2

graph TB

  SubGraph1 --> SubGraph1Flow
  subgraph "SubGraph 1 Flow"
  SubGraph1Flow(SubNode 1)
  SubGraph1Flow -- Choice1 --> DoChoice1
  SubGraph1Flow -- Choice2 --> DoChoice2
  end

  subgraph "Main Graph"
  Node1[Node 1] --> Node2[Node 2]
  Node2 --> SubGraph1[Jump to SubGraph1]
  SubGraph1 --> FinalThing[Final Thing]
end

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports