Skip to content

WIP: Remove snapshot flow

Michael Kozono requested to merge mk/remove-snapshot-flow into master

What does this MR do?

#209988 (closed)

It appears the snapshot for syncing repositories hasn't been working for a while.

It appears this doesn't surface that often because:

  • when there is no error during snapshot, we unset redownload, so further retries use git fetch flow
  • when there is an error during snapshot, the fallback is to go back to git fetch into an empty dir

It is possible for some repos to get stuck in redownload flow without an erroring snapshot method, however, which is a serious problem for those repos since the snapshot method doesn't work.

This MR removes the snapshot method since it doesn't appear to be necessary, and would fix those repos stuck in redownload flow.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports