Skip to content

Fallback to lowest visibility level in snippet visibility radio

What does this MR do?

In snippets form when the default visibility level is not available fallback to the lowest available visibility level.

How to reproduce

  1. In admin panel select as both default and restricted a snippet visibility level
  • Screenshot_2020-05-21_at_10.54.10
  1. Impersonate a non-admin
  2. Create a new Snippet or Project snippets
  • Screenshot_2020-05-23_at_17.36.54
  1. The lowest available visibility level will be selected

Before the fix no visibility level was selected thus a form validation error will be shown on submit.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #216871 (closed)

Edited by Yorick Peterse

Merge request reports