Skip to content

Add LFS workhorse upload path

Jennifer Louie requested to merge 212632-add-LFS-workhorse-upload-path into master

What does this MR do?

This MR adds LFS object upload path to the list of allowed_paths from GitLab-workhorse. This is similar what has been done for packages in !26387 (merged).

This addresses the failures in end-to-end LFS tests #212632 (closed) where the LFS upload paths were being rejected as insecure.

See this comment for the whole explanation why LFS uploads fails: #212632 (comment 341624482)

cc @dbalexandre @10io @rspeicher @jo_shih @stanhu

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #212632 (closed)

Edited by David Fernandez

Merge request reports