Better visualize type of node on Geo Form
What does this MR do?
Closes #213252 (closed)
Currently there is some technical debt on the Geo Form that is causing the UX to be a little confusing.
The main problem being that Primary nodes are no longer able to be created from the UI. Thus leaving the Primary Node checkbox redundant, as you never will be able to check/uncheck it. It basically is now just being used to delimit whether you are updating the primary or a secondary node.
This MR removes the old checkbox, and adds a rounded pill at the top to identify what type of node you are editing. This also adds the assertion that every New node is a secondary.
Screenshots
New Primary | Edit Primary | New Secondary | Edit Secondary | |
---|---|---|---|---|
before | ||||
after | No Longer Possible |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #213252 (closed)