Skip to content

Better visualize type of node on Geo Form

Zack Cuddy requested to merge 213252-hide-primary-checkbox into master

What does this MR do?

Closes #213252 (closed)

Currently there is some technical debt on the Geo Form that is causing the UX to be a little confusing.

The main problem being that Primary nodes are no longer able to be created from the UI. Thus leaving the Primary Node checkbox redundant, as you never will be able to check/uncheck it. It basically is now just being used to delimit whether you are updating the primary or a secondary node.

This MR removes the old checkbox, and adds a rounded pill at the top to identify what type of node you are editing. This also adds the assertion that every New node is a secondary.

Screenshots

New Primary Edit Primary New Secondary Edit Secondary
before New_Primary_-_Old Editing_Primary_-_Old New_Secondary_-_Old Editing_Secondary_-_Old
after No Longer Possible Editing_Primary_-_New New_Secondary_-_New Editing_Secondary_-_New

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #213252 (closed)

Edited by Zack Cuddy

Merge request reports