Remove check for user being applicable codeowner
What does this MR do?
I mistakenly believed this to be desired behavior, and as part of cleanup work ahead of a codeowner's project I "fixed" this. I had thought that we wanted codeowner rules to NOT apply when the user was listed as an owner of one of the applicable rules, essentially assuming their approval as implied due to them taking the git action the check is being applied to. However, this is incorrect, as we still want to push users towards the MR workflow, even when they are in fact an owner who could approve the change.
- Effectively reverts !26027 (merged)
- Related to #217125 (closed)
Merge request reports
Activity
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend João Cunha ( @Alexand
)Ash McKenzie ( @ashmckenzie
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 8a40885d - Remove check for user being applicable codeowner
mentioned in merge request !31613 (closed)
- Resolved by Kerri Miller
assigned to @kerrizor
changed milestone to %13.0
added CodeOwners backend devopscreate groupsource code typebug labels
added 1 commit
- 5e91c4aa - Remove check for user being applicable codeowner
- Resolved by Igor Drozdov
mentioned in issue gitlab-org/release/tasks#1332 (closed)
mentioned in issue #217125 (closed)
- Resolved by Gary Holtz
assigned to @igor.drozdov and unassigned @garyh and @Alexand
added 195 commits
-
5e91c4aa...8fbef813 - 194 commits from branch
master
- 7220b3ab - Remove check for user being applicable codeowner
-
5e91c4aa...8fbef813 - 194 commits from branch
- Resolved by Igor Drozdov
Thank you @igor.drozdov - This one is the same, could you do it, too? !31809 (merged)
mentioned in commit f1ef6fdc
mentioned in issue gitlab-org/release/tasks#1348 (closed)
mentioned in issue gitlab-org/release/tasks#1333 (closed)
added workflowcanary label
added workflowproduction label and removed workflowcanary label