Skip to content
Snippets Groups Projects

Remove check for user being applicable codeowner

Merged Kerri Miller requested to merge kerrizor/remove-code-owner-user-identity-check into master
All threads resolved!

What does this MR do?

I mistakenly believed this to be desired behavior, and as part of cleanup work ahead of a codeowner's project I "fixed" this. I had thought that we wanted codeowner rules to NOT apply when the user was listed as an owner of one of the applicable rules, essentially assuming their approval as implied due to them taking the git action the check is being applied to. However, this is incorrect, as we still want to push users towards the MR workflow, even when they are in fact an owner who could approve the change.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @kerrizor

  • Kerri Miller changed milestone to %13.0

    changed milestone to %13.0

  • Kerri Miller added 1 commit

    added 1 commit

    • 5e91c4aa - Remove check for user being applicable codeowner

    Compare with previous version

  • assigned to @Alexand and @garyh

  • mentioned in issue #217125 (closed)

  • Igor Drozdov assigned to @igor.drozdov and unassigned @garyh and @Alexand

    assigned to @igor.drozdov and unassigned @garyh and @Alexand

  • Kerri Miller added 195 commits

    added 195 commits

    Compare with previous version

  • Igor Drozdov approved this merge request

    approved this merge request

  • Igor Drozdov resolved all threads

    resolved all threads

  • merged

  • Igor Drozdov mentioned in commit f1ef6fdc

    mentioned in commit f1ef6fdc

  • Igor Drozdov resolved all threads

    resolved all threads

  • added workflowproduction label and removed workflowcanary label

  • FYI this is still broken. When using merge trains + codeowners it's impossible to merge now unless you turn off codeowners. You guys need way better testing philosophy vs breaking key features of gitlab willy nilly.

  • Please register or sign in to reply
    Loading