Skip to content

Persist resolution alert dismissal

Savas Vedova requested to merge 212195-propert-dismiss-resolution-alert into master

What does this MR do?

Persists the dismissal of the resolution alert in the standalone vulnerability page. Here is the related issue: #212195 (closed).

Note I acknowledge that the implementation is not perfect. If a user keeps dismissing vulnerabilities hundreds of time, the the cookie value can become large. There are several workarounds for this - for instance splitting the cookie by weekly or monthly values. However I did not want to overengineer this as I am not sure about the usage. For that reason I've set the expiry date to be 90 days, as opposed to 365, which is widely used in GitLab. I would suggest re-iterate on this if we see this causes problems.

Screenshots

Here's the recording:

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports