Skip to content

Detect container registry vendor/version/features

Steve Abrams requested to merge 204839-registry-ping into master

What does this MR do?

This MR is part two of three in implementing #204839 (closed).

It adds the registry_info client call to the container registry which can be used to make a request to the container registry endpoint added in container-registry!166 (merged). The container registry is pinged and the registry returns some meta information in the headers: version and features. This allows us to know if the GitLab instance is using the GitLab container registry or a third party container registry for feature enabling.

The next MR (step 3) will add a rake task (to be run upon instance reconfiguration) that will call this method and update the ApplicationSettings added in !31125 (merged) to store the vendor/version/features values.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Notes

Authored by @jdrpereira, MR managed by @sabrams.

Related #204839 (closed)

Edited by Steve Abrams

Merge request reports