Skip to content

Missing space on system notes

David O'Regan requested to merge 217310 into master

What does this MR do?

A tiny fix for #217310 (closed)

We are adding a selection of margin classes to the system-note-separator to ensure a flush layout when using a d-flex layout on the note_header.vue.

We also remove the extra mr-1 from noteable_note.vue as without the flex classes it creates extra spacing to the right with comments.

Screenshots

Before After
Screenshot_2020-05-11_at_11.29.49 Screenshot_2020-05-11_at_11.30.40
Non Confidential Confidential
Screenshot_2020-05-11_at_14.07.40 Screenshot_2020-05-11_at_14.08.27

Mobile Screenshots

Screenshot_2020-05-11_at_15.37.43

Screenshot_2020-05-11_at_15.37.53

Screenshot_2020-05-11_at_15.39.42

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David O'Regan

Merge request reports