Upgrade s3 sdk without specifying services
What does this MR do?
Upgrades aws-sdk to v3 to take advantage of upload_stream in this MR: !31269 (diffs)
Using the Service Specific Gems Each of the instructions above suggested using version 3 of the aws-sdk gem. This will work and is the shortest path to upgrading. It will however install 75+ service specific gems. You may choose to replace your dependency on the aws-sdk gem with service specific gems.
If my application depends on Amazon DynamoDB and Amazon S3, I could make the following changes:
In my Gemfile:
#gem 'aws-sdk', '~> 3' gem 'aws-sdk-dynamodb', '~> 1' gem 'aws-sdk-s3', '~> 1' In my code:
#require 'aws-sdk' require 'aws-sdk-s3' require 'aws-sdk-dynamodb' If you are a library maintainer, and you depend on the AWS SDK for Ruby, you should use service specific gems. Do no force your users to install every AWS service gem if you only depend on one.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team