Fix: "Annotations missing from Metric Charts"
What does this MR do?
Metrics dashboard annotations are not displayed due to:
The way new javascript Date objects are created is apparently different in Chrome and Firefox. Chrome is more liberal but firefox requires the date to be in a certain format.
Currently, the frontend receives date in
2020-05-05 04:22:22 UTC
string format which is then converted to a date object. Firefox considers this incorrect format and is silently throwing errors. There is a MDN reference here talking about the format that should be used https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Invalid_date.Either ISO date string
2020-05-05T04:22:22Z
or2020 05 05 04:22:22 UTC
are acceptable for Firefox and Chrome.
In order to address that, we need to use Time
format in graphql resources which will translate timestamps into iso8601 compatible format.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
Reports #216963 (closed)