Skip to content

Loosen prop requirement

Savas Vedova requested to merge 211827-loosen-prop-requirement into master

What does this MR do?

When a project has no pipeline data, we display an information about how to setup vulnerability scanning in the security dashboard. That view is not using some props that are defined as required. Although there is no visual bug, we do log into the console an error message. This MR fixes those error messages by loosening the prop requirement.

In order to reproduce it in both security dashboards:

  1. Pick a project that has no pipeline data
  2. Visit the Security & Compliance tab on the left.
  3. Open your console, if you have the feature flag (:first_class_vulnerabilities) enabled locally, you should see an error message (if you check out this branch you'll see that the error message is gone).
  4. If you disable the feature flag, you'll be shown the REST API backed security dashboard. In that case, you'll see a similar error on master branch.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #211827 (closed)

Edited by Savas Vedova

Merge request reports