Skip to content

Enable :snippets_vue by default

Denys Mishunov requested to merge 207235-snippets-vue-ff-on-by-default into master

What does this MR do?

Enables the :snippets_vue feature flag by default

After #34820 (closed) has been done behind the :snippets_vue feature flag, the flag has been enabled globally on gitlab.com at the end of %12.9 and was enabled during the whole %12.10 without any major issue. A couple of minor visual glitches were promptly fixed at the end of %12.9. So it is considered to be pretty safe to enable this feature by default.

This also enables a gateway for myriads of other features the most important of which is the support for Versioned Snippets (note the blue button in the "After" screenshot below).

Why not removing the flag completely?

There are some questions related to feature specs and QA tests that need to be addressed before the flag can be removed completely.

Screenshots

Before After
Screenshot_2020-05-08_at_12.33.52 Screenshot_2020-05-08_at_12.35.30

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #207235 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports