Add License check for the 'send emails from Admin area' feature.
What does this MR do?
Our docs say that Sending emails from Admin area feature is GitLab Starter and above.
But the code (controller and views) that implements this feature is not guarded by any License.feature_available? checks, even though the controller and views of this feature are inside the ee/ folder.
This means that we have a bug when a customer was running an EE plan, and their license expires and falls back to "Core" features.
In this scenario, the "Send emails from Admin area" feature will still be available for them, since it is not guarded by any feature_available? check.
(However, this is not a problem when customers are running GitLab core from the beginning, because it would not contain the /ee folder anyway)
This MR fixes this bug by adding License checks to the controller and views of this feature.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team