Skip to content

Mark CreateCommitSignatureWorker as idempotent

What does this MR do?

The CreateCommitSignatureWorker processed 38k jobs, where just 123 of these were "duplicates" in just 2 days. Still, 15 hours were spent processing these duplicates (related to the incident at gitlab-com/gl-infra/scalability#259 (comment 330182742)):

https://log.gprd.gitlab.net/goto/3ee5a0f44c8b064944225acaa86213e4 (the link doesn't show this high value that was seen during an incident)

Marking this job as idempotent also makes it eligible for deduplication https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#deduplication, which could save some resources.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports