Skip to content

Add Feature Flag User Lists Controller With IidRoute

Jason Goodman requested to merge user-lists-controller-plus-fix into master

What does this MR do?

Add a skeletal controller for feature flag user lists.

This will be filled in later on the frontend to implement the feature.

Issue: #13308 (closed)

Note

This MR is a duplicate of !30772 (merged) with a fix to include IidRoute in the FeatureFlags::UserList model.

!30772 (merged) broke master: #216960 (closed)

Because the FeatureFlags::UserList model did not include IidRoutes: #216960 (comment 338359306)

!30772 (merged) was reverted: !31355 (merged)

So this MR reintroduces the changes from !30772 (merged) along with a spec to make sure IidRoutes are included in the model: !31392 (e65f9483)

Screenshots

New

Screen_Shot_2020-05-05_at_12.05.23_PM

Edit

Screen_Shot_2020-05-05_at_12.06.04_PM

Show

Screen_Shot_2020-05-05_at_12.06.17_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports