Skip to content

Improve label selection performance in Vue Labels dropdown

Kushal Pandya requested to merge kp-fix-vue-labels-dropdown-bugs into master

What does this MR do?

Fixes following issues in labels select dropdown;

  • Improve label select performance by not waiting for state update to show on UI (and do it via local data prop).
    • This change reduced duration of selecting a label (i.e. Update Layer Tree activity) from ~400ms down to ~2ms.
  • Prevent dropdown from closing while clearing search input field.
  • Fix a bug where select and unselecting same label multiple times causes that label to show up twice in values section.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kushal Pandya

Merge request reports