Skip to content

Set use_cookies_with_metadata to true

Heinrich Lee Yu requested to merge 197344-use-cookies-with-metadata into master

What does this MR do?

This is forward-compatible, meaning old sessions would continue to work, but it is not backward-compatible so the sessions won't work if we rollback to Rails 5.2.

Since we've already running Rails 6 for a while now, we can make this change to use the new Rails 6 default value.

https://blog.saeloun.com/2019/11/12/rails-6-adds-purpose-metadata-to-cookies.html

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #197344 (closed)

Edited by Nick Thomas

Merge request reports